Improve #testing section #169
Conversation
…estCases; This fixes coverage testing
Also fix Squeak-Trunk build on AppVeyor and improve Windows builds.
|
@dalehenrich I've made a lot of progress on Windows support for Squeak/Pharo that I've already merged into |
| pharo_zeroconf="$(download_file "get.pharo.org/vm30")" || print_error_and_exit "Pharo-3.0 vm download failed." | ||
| bash -c "${pharo_zeroconf}" || print_error_and_exit "Pharo-3.0 vm download failed." | ||
| download_file "get.pharo.org/vm30" "$(pwd)/zeroconfig" | ||
| bash "$(pwd)/zeroconfig" | ||
| popd > /dev/null |
There was a problem hiding this comment.
I was out of town over the weekend, but now I'm back ... I am concerned that an error during download_file or running the zeroconfig script will not cause the run.sh script to fail and that will mean that it will be difficult to understand what actually failed ...
There was a problem hiding this comment.
The download_file function now does error handling and exits on error.
See:
Line 220 in 4b1fcaf
There was a problem hiding this comment.
how about the zeroconfig script? That guy still needs to have explicit error test since it is not a script controlled by smalltalkCI
|
There are way too many files to look at at this point ... but I think I scanned the important changes and of course the tests are all passing so I think that this looks good ... modulo the zeroconfig script error handling |
|
Sorry about that, but thanks for checking the important parts. As I said, |
| pharo_zeroconf="$(download_file "get.pharo.org/30")" || print_error_and_exit "Pharo-3.0 image download failed." | ||
| bash -c "${pharo_zeroconf}" || print_error_and_exit "Pharo-3.0 image download failed." | ||
| download_file "get.pharo.org/30" "$(pwd)/pharo30_zeroconfig" | ||
| bash "$(pwd)/pharo30_zeroconfig" |
There was a problem hiding this comment.
@fniephaus my concern is that bash "$(pwd)/pharo30_zeroconfig" is no longer protected by a status check ... I understand that download_file does it's own error checking ... but bash "$(pwd)/pharo30_zeroconfig" should be changed to:
bash "$(pwd)/pharo30_zeroconfig" || print_error_and_exit "Pharo-3.0 image download failed."
or something similar ....
There was a problem hiding this comment.
...unless bash magically causes run.sh to exit with an error status if the script it is running has a non-zero exit code ...
Hi @dalehenrich,
Would you be so kind and skim over this PR?
I have moved the
#projectslogic fromSmalltalkCIGemStonetoSmalltalkCIand I have unified the way#classes,#packagesand#categorieswork across all dialects.This fixes #58 and #135.
Best,
Fabio