Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #360 #361

Merged
merged 1 commit into from Mar 21, 2018
Merged

Fix #360 #361

merged 1 commit into from Mar 21, 2018

Conversation

guillep
Copy link
Collaborator

@guillep guillep commented Mar 21, 2018

Rename ZnCrPortableWriteStream into ZnNewLineWriterStream

@guillep
Fix hpi-swa#360
17416c5 
Rename ZnCrPortableWriteStream into ZnNewLineWriterStream
@fniephaus
Copy link
Member

Does this need to be backwards compatible?

@guillep
Copy link
Collaborator Author

guillep commented Mar 21, 2018

Nope, this is for Pharo-alpha. The class that was renamed does not exist in Pharo<7. It was introduced in Pharo7 and now renamed.

@fniephaus
Copy link
Member

Ok, thanks!

@fniephaus fniephaus merged commit 17416c5 into hpi-swa:master Mar 21, 2018
fniephaus added a commit that referenced this pull request Mar 21, 2018
@fniephaus
Generate new version for #361
c0360b0
@fniephaus
Copy link
Member

The change should now be live. Thanks again for the fix!

@fniephaus fniephaus self-assigned this Mar 21, 2018
@guillep
Copy link
Collaborator Author

guillep commented Mar 21, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

Assignees

@fniephaus fniephaus

Labels
Pharo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guillep @fniephaus @jecisc