Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Ip and dns #431

Closed
krichly opened this issue Feb 27, 2019 · 2 comments · Fixed by #436
Closed

Edit Ip and dns #431

krichly opened this issue Feb 27, 2019 · 2 comments · Fixed by #436
Assignees
Labels
enhancement New feature or request prio: high This is a high priority issue.

Comments

@krichly
Copy link
Contributor

krichly commented Feb 27, 2019

Description

For an administrator, it should be possible to edit the dns and ip for existing vms.

@krichly krichly added the prio: high This is a high priority issue. label Feb 27, 2019
@krichly krichly added this to To do in Project Board via automation Feb 27, 2019
@bdaase
Copy link
Contributor

bdaase commented Feb 27, 2019

@MrModder As you already said today, we have to talk about whether we can reuse the config page. This would imply, that the editing of users is possible on the config page.

@BraunTom BraunTom moved this from To do to In progress in Project Board Feb 27, 2019
@BraunTom BraunTom self-assigned this Feb 27, 2019
@BraunTom BraunTom moved this from In progress to Needs review in Project Board Feb 27, 2019
@LeonMatthes
Copy link
Contributor

@krichly @BjoernDaase I strongly encourage using a single edit page for the vms, after creation to configure IP and DNS, and also to edit the VM afterwards.
This would better conform to the REST principles, provide better reusability, and even give greater configuration control after creating the VM, if need be.
We would only have to change the redirect url depending on whether someone was redirected there from creation, or just edited the VM

bdaase added a commit that referenced this issue Mar 5, 2019
@chrisma chrisma added the enhancement New feature or request label Mar 6, 2019
Project Board automation moved this from Needs review to Done Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio: high This is a high priority issue.
Projects
Project Board
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants