Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admins can configure ip and dns of vms #436

Merged
merged 8 commits into from
Mar 6, 2019
Merged

admins can configure ip and dns of vms #436

merged 8 commits into from
Mar 6, 2019

Conversation

BraunTom
Copy link
Contributor

should close #431

LeonMatthes
LeonMatthes requested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@LeonMatthes LeonMatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should see the VirtualMachineConfig objects more as the models for Virtual Machines. Therefore we can just use rails convention to implement the corresponding controller actions

app/controllers/vms_controller.rb Outdated Show resolved Hide resolved
app/controllers/vms_controller.rb Outdated Show resolved Hide resolved
app/controllers/vms_controller.rb Outdated Show resolved Hide resolved
spec/views/vms/edit.html.erb_spec.rb Show resolved Hide resolved
@BraunTom BraunTom added WIP work is still in progess for this PR and removed Review Required labels Feb 28, 2019
@BraunTom BraunTom added Review Required and removed WIP work is still in progess for this PR labels Mar 1, 2019
LeonMatthes
LeonMatthes requested changes Mar 1, 2019
View reviewed changes
app/controllers/vms_controller.rb Outdated Show resolved Hide resolved
@chrisma
Copy link
Contributor

chrisma commented Mar 6, 2019 •
edited

This PR seems ready for merging 💯

@bdaase bdaase merged commit 88e3d7d into dev Mar 6, 2019
@bdaase bdaase deleted the #431/EditIpAndDns branch March 6, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthes LeonMatthes LeonMatthes approved these changes

@chrisma chrisma chrisma approved these changes

@bdaase bdaase bdaase left review comments

@krichly krichly Awaiting requested review from krichly

@rteusner rteusner Awaiting requested review from rteusner

Assignees
No one assigned
Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Ip and dns
4 participants
@BraunTom @chrisma @LeonMatthes @bdaase