Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

510/remove JSON REST interface #538

Closed
wants to merge 24 commits into from
Closed

510/remove JSON REST interface #538

wants to merge 24 commits into from

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Apr 3, 2019 •
edited

  • Remove jbuilder gem
  • Remove jbuilder files
  • Only respond to HTML, not JSON, simplifying controllers
  • Refactor RequestController

Ref #510

Continued in #541

@chrisma chrisma added the WIP work is still in progess for this PR label Apr 3, 2019
@chrisma chrisma changed the title 510/remove json rest 510/remove JSON REST interface Apr 3, 2019
@chrisma
Fix(Requests Controller): Remove JSON from 'reject' method
f703813
@chrisma
Refacor(Requests Controller): 'destroy' method
1d12014
@chrisma
Refactor(Requests Controller): 'create' method
ff5105d
@chrisma
Refactor(Requests Controller): introduce 'set_request_templates'
0ee964d
@chrisma
Refactor(Requests Controller): Remove 'split requests'
b2f8a0a
@chrisma
Fix(Requests Form): Display base errors
0581a76
@chrisma
Refactor(Requests Controller): Make 'notify users' private
92e05ec
@chrisma
Refactor(Requests Controller): Remove 'authenticate_state_change'
aee6cb5
@chrisma
Refactor(Requests Controller): Remove ref to 'authenticate_state_change'
e17a37c
@chrisma
Refactor(Requests Controller): Use 'set_request'
ad3f222
@chrisma
Refactor(Requests Controller): 'update' method
6ef9aa3
@chrisma
Refactor(Requests Controller): 'index' db access
20dae88
@chrisma
Refactor(Requests Controller): 'safe_create_vm_for'
6716bd0
@chrisma
Refactor(Requests Controller): Remove 'notice_for'
24fc8a2
@chrisma
Refactor(Requests Controller): Remove 'prepare_params'
3754542
@chrisma
Chore(Requests Controller): Whitespace
a554364
@chrisma chrisma added Review Required and removed WIP work is still in progess for this PR labels Apr 3, 2019
krichly
krichly reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@krichly krichly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we could think about moving/merging functionality from request to VM in a new issue.

app/controllers/requests_controller.rb Show resolved Hide resolved
app/controllers/requests_controller.rb
else
requests = Request.where(user: current_user)
end
@pending_requests = requests.select(&:pending?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we could use scopes here.
https://stackoverflow.com/questions/41194374/rails-5-how-to-write-a-scope

Copy link
Contributor Author

@chrisma chrisma Apr 25, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Rails enums automatically create scopes, i.e. Request.all.select(&:pending?) == Request.pending

@chrisma chrisma mentioned this pull request Apr 25, 2019
Merged
@chrisma chrisma added invalid This doesn't seem right and removed Review Required labels Apr 25, 2019
@chrisma chrisma closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichly krichly krichly left review comments

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisma @krichly @bdaase