Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

510/remove json rest v2 #541

Merged
merged 23 commits into from
Apr 25, 2019
Merged

510/remove json rest v2 #541

merged 23 commits into from
Apr 25, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Apr 25, 2019 •
edited
Loading

Continuation of #538

  • Remove jbuilder gem
  • Remove jbuilder files
  • Only respond to HTML, not JSON, simplifying controllers
  • Refactor RequestController

Ref #510

chrisma and others added 22 commits April 3, 2019 14:53
@chrisma
Fix(Gemfile): Remove jbuilder gem and associated files
5d07d1b
@chrisma
Fix(Requests controller): Remove extracted methods
f86ffc9
@chrisma
Fix(Requests Controller): Remove JSON from 'reject' method
f703813
@chrisma
Refacor(Requests Controller): 'destroy' method
1d12014
@chrisma
Refactor(Requests Controller): 'create' method
ff5105d
@chrisma
Refactor(Requests Controller): introduce 'set_request_templates'
0ee964d
@chrisma
Refactor(Requests Controller): Remove 'split requests'
b2f8a0a
@chrisma
Fix(Requests Form): Display base errors
0581a76
@chrisma
Refactor(Requests Controller): Make 'notify users' private
92e05ec
@chrisma
Refactor(Requests Controller): Remove 'authenticate_state_change'
aee6cb5
@chrisma
Refactor(Requests Controller): Remove ref to 'authenticate_state_change'
e17a37c
@chrisma
Refactor(Requests Controller): Use 'set_request'
ad3f222
@chrisma
Refactor(Requests Controller): 'update' method
6ef9aa3
@chrisma
Refactor(Requests Controller): 'index' db access
20dae88
@chrisma
Refactor(Requests Controller): 'safe_create_vm_for'
6716bd0
@chrisma
Refactor(Requests Controller): Remove 'notice_for'
24fc8a2
@chrisma
Refactor(Requests Controller): Remove 'prepare_params'
3754542
@chrisma
Chore(Requests Controller): Whitespace
a554364
@chrisma
Merge branch 'dev' into 510/remove_json_rest
08be7ca
@chrisma
Merge branch 'dev' into 510/remove_json_rest
10aff38
@bdaase
Merge branch 'dev' into 510/remove_json_rest
872db76
@chrisma
Merge branch 'dev' into 510/remove_json_rest
9c0ee3b
@chrisma chrisma mentioned this pull request Apr 25, 2019
Closed
@chrisma chrisma merged commit 6b7ff09 into dev Apr 25, 2019
@chrisma chrisma deleted the 510/remove_json_rest_v2 branch April 25, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisma @bdaase