Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move all login method to macros #712

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

move all login method to macros #712

wants to merge 1 commit into from

Conversation

lHydra
Copy link

@lHydra lHydra commented Oct 26, 2018

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.164% when pulling fc94af9 on lHydra:684_move_login_method_to_macros into 5166b95 on hpi-schuelerklub:dev.

bjrne
bjrne approved these changes Oct 27, 2018
View reviewed changes
Copy link
Collaborator

@bjrne bjrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution! We require a second review, as soon as it is in, we'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjrne bjrne bjrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lHydra @coveralls @bjrne