SHO support for HMAC #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonschmidt99
force-pushed
the
hmac-sha-256-sho
branch
from
1952eb3
to
b8332e2
Compare
leonschmidt99
force-pushed
the
hmac-sha-256-sho
branch
from
9ee5f9c
to
55598a6
Compare
konradh
requested changes
Jan 17, 2023
… various hash algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I found out when implementing the System Parameter Generation in the KVAC system, Signal actually uses an HMAC SHA 256 SHO object for this. So I decided to add HMAC support to our SHO as well, so that we can keep up with the compatibility to Signal's implementation.
This is a late addition to #7