This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Documentation improvements #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few files that were loaded in the geofencing example as well as the API for the JSON example so they work properly when the documentation is viewed under TLS. There are still some mixed content warnings that need to be fixed, but they do not interfere with viewing the documentation.
This switches all of the links in the logo and in a few of the root pages to use relative links instead of hard-coding the paths. The hard-coded paths made it incredibly difficult to view the documentation locally, as your are constantly switched to the live version of the documentation.
This fixed the mixed content warning in the map types page that resulted from using the non-SSL endpoints for the OpenStreetMap Tile API. The image paths have been switched, so there should no longer be a mixed content warning. This also removes the CloudMade example map, as the API key does not appear to be active so it has not been loading the map at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few things the other day when checking out this library for the first time, and #421 inspired me to actually fix the issues (instead of just whitelisting the website and moving on).
This should close #421.