Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to the output git versions #217

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Write to the output git versions #217

merged 1 commit into from
Aug 21, 2022

Conversation

peterrum
Copy link
Collaborator

motivated by the comment #204 (comment)

We should also output the parameter files and the list of particles to make everything reproducible. @vovannikov Could take this task take on?

See also: dealii/dealii#14204

@mschreter Are we somewhere monitoring the version of deal.II/MeltPoolDG?

@vovannikov
Copy link
Collaborator

@peterrum, yea, I could handle that. Do you have any preferences on how to store that data? I thought of outputting the corresponding *.prm and *.cloud files directly to the console as all those things would stay together. I think it is a bit better than storing those files separately and indicating somehow that the output is chained with them. Does it work for you?

@vovannikov vovannikov merged commit 9b688e6 into master Aug 21, 2022
@peterrum
Copy link
Collaborator Author

Yes dumping it to the same output file is reasonable to me. We print so much to console anyway.

Comment on lines +28 to +29
SET(HYPER_DEAL_GIT_BRANCH "@HYPER_DEAL_GIT_BRANCH@")
SET(HYPER_DEAL_GIT_REVISION "@HYPER_DEAL_GIT_REVISION@")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@mschreter
Copy link
Collaborator

@peterrum no, we don't track the particular deal.II version. In the ideal case it should be the deal.II master branch at the particular date of merging. However, I think your approach sounds reasonable and I'll open up an issue for that in MeltPoolDG. Thanks!

@peterrum
Copy link
Collaborator Author

peterrum commented Aug 23, 2022

SET(HYPER_DEAL_GIT_BRANCH "@HYPER_DEAL_GIT_BRANCH@")
SET(HYPER_DEAL_GIT_REVISION "@HYPER_DEAL_GIT_REVISION@")

@mschreter Haven't you heard about plasma state sintering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants