Do not use --date=iso-strict in DEAL_II_QUERY_GIT_INFORMATION #14204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
reviewed
Aug 20, 2022
| # | ||
|
|
||
| EXECUTE_PROCESS( | ||
| COMMAND ${GIT_EXECUTABLE} log -n 1 --pretty=format:"revision=%H, shortrev=%h, date=%cd" --date=iso-strict | ||
| COMMAND ${GIT_EXECUTABLE} log -n 1 --pretty=format:"revision=%H, shortrev=%h, date=%cd" --date=default |
There was a problem hiding this comment.
Let's not switch to default here. The reason for "iso-strict" here is to get a parseable output: 2022-08-04T13:22:13-04:00.
Default output produces probably a locale dependent string - which is a nightmare.
Would you mind testing #14206 which avoids the option for all git versions older than 2.2.
|
Closing in favor of #14206. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tamiko I have on an old cluster problems with
iso-strict, since on that system git (git version 1.8.3.1) does not know this format. The result that I get know info regarding the git version at all. Could we switch to the default format? What was the reason to selecting that format?