Fix microbenchmarks #361
Merged
Fix microbenchmarks #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
approved these changes
Sep 23, 2022
|
Should we add running the microbenchmarks to CI so that they don't break in future? |
fangerer
approved these changes
Sep 26, 2022
| @@ -65,7 +65,8 @@ static HPy allocate_tuple_impl(HPyContext *ctx, HPy self) | |||
| /* Foo type */ | |||
|
|
|||
| typedef struct { | |||
| PyObject_HEAD | |||
| long x; | |||
| long y; | |||
| } FooObject; | |||
There was a problem hiding this comment.
Why do we even need FooObject? An HPy type can also have .basicsize = 0.
There was a problem hiding this comment.
it's because we wanted to have non-0 allocations in test_allocate_*, they are more likely to be representative.
ah good point. I'll try to fix that |
yes, good idea |
…ocation benchmarks it makes more sense to use a struct whose size is >=0
fangerer
force-pushed
the
antocuni/fix-microbenchmarks
branch
from
79f30c0
to
ef6cdb0
Compare
fangerer
force-pushed
the
antocuni/fix-microbenchmarks
branch
from
ef6cdb0
to
722fe9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microbenchmarks got slightly out of date and didn't build, fix it and improve the readme