Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in theme_ipsum_rc.Rd #24

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Fix typo in theme_ipsum_rc.Rd #24

merged 1 commit into from
Oct 14, 2017

Conversation

phillyo
Copy link
Contributor

@phillyo phillyo commented Oct 13, 2017

fixed typo in description of the arguments "plot_title_family, plot_title_face, plot_title_size, plot_title_margin"

fixed typo in description of the arguments "plot_title_family, plot_title_face, plot_title_size, plot_title_margin"
@phillyo phillyo changed the title Update theme_ipsum_rc.Rd Fix typo in theme_ipsum_rc.Rd Oct 13, 2017
@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #24 into master will increase coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   52.89%   54.56%   +1.67%     
==========================================
  Files           9        9              
  Lines         380      438      +58     
==========================================
+ Hits          201      239      +38     
- Misses        179      199      +20
Impacted Files Coverage Δ
R/theme-ipsum.r 100% <0%> (ø) ⬆️
R/aaa.r 100% <0%> (ø) ⬆️
R/check.r 100% <0%> (ø) ⬆️
R/utils.r 0% <0%> (ø) ⬆️
R/roboto-condensed.r 44.57% <0%> (+0.69%) ⬆️
R/scales.r 100% <0%> (+7.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c4501...82003cd. Read the comment docs.

@hrbrmstr
Copy link
Owner

#ty!

Could you also add yourself as a person() in the DESCRIPTION with a role = c("ctb") and tick the version up to 0.3.4? I like to ensure folks get credit for their contributions.

@hrbrmstr hrbrmstr merged commit aa1eacb into hrbrmstr:master Oct 14, 2017
@phillyo phillyo deleted the patch-2 branch October 16, 2017 12:38
@phillyo
Copy link
Contributor Author

phillyo commented Oct 16, 2017

done! wouldn't have been necessary, but thanks a lot! i'll try contribute more to make me really deserve that ctb role :)

hrbrmstr added a commit that referenced this pull request Mar 5, 2020
Fix typo in theme_ipsum_rc.Rd
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants