-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command line option: quiet #113
Conversation
Move generated BuildInfo.scala to co.uproot.abandon Add version xml elements to Journal and Balance exports with the version from BuildInfo.scala
Add new command line parameter Add parameter to differentiate between versioned xml and nonversioned one Start to fix tests Make client xml code compile
… element is created
Set default value of versioned to be true Set the versioned value for cli test to false
Don't write to console if the quite is added to cmd args Make tests happy Set CliTestRunner.scala to quite logs
Hello @hrj! This is a stab at #111 |
Hey @alexanderzafirov ! Firstly, sorry, there's been a slight misunderstanding. The Secondly, you need to create a new branch and rebase these changes on top of upstream master. Something along these lines: #create new branch
git checkout -b i111-quiet
# add this repository if not already done
git remote add hrj git@github.com:hrj/abandon.git
# get all the latest changes from this repo
git fetch hrj
# merge the latest
git merge hrj/master
# rebase
git rebase hrj/master
# push to your fork
git push origin i111-quiet After this you can create a new pull-request from your branch About architecture, sure! You can create a new issue for it and we can discuss there. cheers! |
Introduce quiet parameter in Settings
Don't write to console if the quite is added to cmd args
Make tests happy
Set CliTestRunner.scala to quite logs