Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line option: quiet #113

Closed
wants to merge 10 commits into from
Closed

Command line option: quiet #113

wants to merge 10 commits into from

Conversation

z4f1r0v
Copy link
Contributor

@z4f1r0v z4f1r0v commented Nov 4, 2016

Introduce quiet parameter in Settings
Don't write to console if the quite is added to cmd args
Make tests happy
Set CliTestRunner.scala to quite logs

Alexander Zafirov added 10 commits October 23, 2016 23:38
Move generated BuildInfo.scala to co.uproot.abandon
Add version xml elements to Journal and Balance exports with the version from BuildInfo.scala
Add new command line parameter
Add parameter to differentiate between versioned xml and nonversioned one
Start to fix tests
Make client xml code compile
Set default value of versioned to be true
Set the versioned value for cli test to false
Don't write to console if the quite is added to cmd args
Make tests happy
Set CliTestRunner.scala to quite logs
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 67.368% when pulling cc6d25e on alexanderzafirov:master into e3b1d40 on hrj:master.

@z4f1r0v
Copy link
Contributor Author

z4f1r0v commented Nov 4, 2016

Hello @hrj! This is a stab at #111
I decided to go with an extra parameter to Settings since this is a setting to the app. I don't like the way this parameter "spills" in all the tests and is actually only used in the App.scala. Nevertheless I decided that this needs to be addressed in a separate PR.
If you are happy with this maybe we can have a discussion about the architecture of the app. I see some concepts could be refined. IntelliJ also suggests some modifications to the code - mostly cosmetics, I guess - that can also be applied if you agree.

@hrj
Copy link
Owner

hrj commented Nov 5, 2016

Hey @alexanderzafirov !

Firstly, sorry, there's been a slight misunderstanding. The quiet parameter is supposed to suppress "log" output, such as "Processing file xyz.ledger" or "Writing to pqr.xml". The actual reports should not be suppressed.

Secondly, you need to create a new branch and rebase these changes on top of upstream master.

Something along these lines:

#create new branch
git checkout -b i111-quiet

# add this repository if not already done
git remote add hrj git@github.com:hrj/abandon.git

# get all the latest changes from this repo
git fetch hrj

# merge the latest
git merge hrj/master

# rebase
git rebase hrj/master

# push to your fork
git push origin i111-quiet

After this you can create a new pull-request from your branch i111-quiet to the master branch here. If you are comfortable with git, you could update this PR in place, but to keep things simple I will close this PR.

About architecture, sure! You can create a new issue for it and we can discuss there.

cheers!

@hrj hrj closed this Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants