-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncspot-0.9.5 build failure #714
Comments
Hi there, you need the latest Rust version for this (1.58.0) which supports captured identifiers: https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings |
@hrkfdn Thank you for the quick reply. 1.57.0 should hit main this week and I'll move to 1.58.0 but, I can not merge because it will give the users a broken package. |
Let's close this as there's a logical explanation. |
Should be a fairly simple patch as that feature is only used in like one or
two log statements, I can provide a diff if that helps.
…On Wed, Jan 19, 2022, 10:38 AM pin ***@***.***> wrote:
@hrkfdn <https://github.com/hrkfdn> Thank you for the quick reply.
This will have to wait than, we usually keep rust one version behind as it
causes trouble with other things. like libresvg.
NetBSD is still on v1.56.1 but, I usually run +1, so I have 1.57.0 on my
system.
1.57.0 should hit main this week and I'll move to 1.58.0 but, I can not
merge because it will give the users a broken package.
I will add a note that we are keeping 0.9.4 for now.
—
Reply to this email directly, view it on GitHub
<#714 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE3LFPKDKGM4NXNERDQTDUW2A73ANCNFSM5MJMRIRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That would be fine if you like, else we keep 0.9.4 until we have rust 1.58.0 which would be end of February beginning of March. But, yeah I can push another patch. |
@0323pin Here's a diff in case you still want to build it with older Rust versions diff --git a/src/ui/listview.rs b/src/ui/listview.rs
index 17fead7..e6c72b6 100644
--- a/src/ui/listview.rs
+++ b/src/ui/listview.rs
@@ -85,7 +85,7 @@ impl<I: ListItem> ListView<I> {
pub fn content_height_with_paginator(&self) -> usize {
let content_len = self.content.read().unwrap().len();
- log::info!("content len: {content_len}");
+ log::info!("content len: {}", content_len);
// add 1 more row for paginator if we can paginate
if self.can_paginate() {
@@ -97,7 +97,7 @@ impl<I: ListItem> ListView<I> {
fn can_paginate(&self) -> bool {
let loaded = self.get_pagination().loaded_content();
- log::info!("can paginate: {loaded}");
+ log::info!("can paginate: {}", loaded);
self.get_pagination().max_content().unwrap_or(0) > self.get_pagination().loaded_content()
} |
@hrkfdn I've just kick-started a build with this. Thanks! |
@hrkfdn Merged, https://mail-index.netbsd.org/pkgsrc-changes/2022/01/19/msg247190.html You are probably aware of these warnings, they have been there most of the time but, leaving them here anyway,
|
@0323pin Yeah, those are due to deactivated features. They could probably be removed with feature gates, but it'd really hinder readability. In any case they're not problematic. |
Hi,
NetBSD package maintainer here. The new release (0.9.5) fails to build on NetBSD-current (9.99.93) using rust-1.57.0 with the following error.
Any possibility to fix this?
The text was updated successfully, but these errors were encountered: