Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support set family #64

Merged
merged 5 commits into from
Feb 13, 2021
Merged

Feature/support set family #64

merged 5 commits into from
Feb 13, 2021

Conversation

hrntsm
Copy link
Owner

@hrntsm hrntsm commented Feb 13, 2021

変更点

  • STBからKaramba3Dへの変換の際、断面のファミリー名を選べるようにした

対応するIssue番号

close #63

if (!DA.GetData(1, ref name[1])) { return; }
if (!DA.GetData(2, ref name[2])) { return; }
if (!DA.GetData(3, ref name[3])) { return; }
if (!DA.GetData(4, ref name[4])) { return; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

if (!DA.GetData(2, ref name[2])) { return; }
if (!DA.GetData(3, ref name[3])) { return; }
if (!DA.GetData(4, ref name[4])) { return; }
if (!DA.GetData(5, ref name[5])) { return; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

if (!DA.GetData(3, ref name[3])) { return; }
if (!DA.GetData(4, ref name[4])) { return; }
if (!DA.GetData(5, ref name[5])) { return; }
if (!DA.GetData(6, ref name[6])) { return; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

if (!DA.GetData(4, ref name[4])) { return; }
if (!DA.GetData(5, ref name[5])) { return; }
if (!DA.GetData(6, ref name[6])) { return; }
if (!DA.GetData(7, ref name[7])) { return; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

@codeclimate
Copy link

codeclimate bot commented Feb 13, 2021

Code Climate has analyzed commit 8a46b84 and detected 0 issues on this pull request.

View more on Code Climate.

@hrntsm hrntsm merged commit 78c2964 into develop Feb 13, 2021
@hrntsm hrntsm deleted the feature/support-set-family branch February 13, 2021 03:22
@hrntsm hrntsm mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to allow setting cross section family name
1 participant