Remove "SwapBuffers" from the GraphicsContext interface.

Buildfixes More buildfix headless buildfix One more buildfix
hrydgard · Aug 10, 2023 · 1ea11c2 · 1ea11c2
1 parent ed9b033
commit 1ea11c2
Show file tree

Hide file tree

Showing 20 changed files with 5 additions and 33 deletions.
diff --git a/Common/GraphicsContext.h b/Common/GraphicsContext.h
@@ -16,8 +16,6 @@ class GraphicsContext {
 	virtual void Shutdown() = 0;
 	virtual void SwapInterval(int interval) = 0;
 
-	virtual void SwapBuffers() = 0;
-
 	// Used during window resize. Must be called from the window thread,
 	// not the rendering thread or CPU thread.
 	virtual void Pause() {}

diff --git a/Core/Core.cpp b/Core/Core.cpp
@@ -227,10 +227,6 @@ void Core_RunLoop(GraphicsContext *ctx) {
 		if (sleepTime > 0)
 			sleep_ms(sleepTime);
 	}
-
-	if ((!windowHidden && !Core_IsStepping()) || menuThrottle) {
-		ctx->SwapBuffers();
-	}
 }
 
 void Core_DoSingleStep() {

diff --git a/Qt/QtMain.h b/Qt/QtMain.h
@@ -70,7 +70,6 @@ class QtGLGraphicsContext : public GraphicsContext {
 		// See TODO in constructor.
 		// renderManager_->SwapInterval(interval);
 	}
-	void SwapBuffers() override {}
 	void Resize() override {}
 
 	Draw::DrawContext *GetDrawContext() override {

diff --git a/SDL/SDLGLGraphicsContext.h b/SDL/SDLGLGraphicsContext.h
@@ -19,10 +19,6 @@ class SDLGLGraphicsContext : public GraphicsContext {
 	void Shutdown() override;
 	void ShutdownFromRenderThread() override;
 
-	void SwapBuffers() override {
-		// Do nothing, the render thread takes care of this.
-	}
-
 	// Gets forwarded to the render thread.
 	void SwapInterval(int interval) override;
 

diff --git a/SDL/SDLMain.cpp b/SDL/SDLMain.cpp
@@ -1452,8 +1452,6 @@ int main(int argc, char *argv[]) {
 				break;
 		}
 
-		graphicsContext->SwapBuffers();
-
 		{
 			std::lock_guard<std::mutex> guard(g_mutexWindow);
 			if (g_windowState.update) {

diff --git a/SDL/SDLVulkanGraphicsContext.h b/SDL/SDLVulkanGraphicsContext.h
@@ -26,10 +26,6 @@ class SDLVulkanGraphicsContext : public GraphicsContext {
 
 	void Shutdown() override;
 
-	void SwapBuffers() override {
-		// We don't do it this way.
-	}
-
 	void Resize() override;
 
 	void Poll() override;

diff --git a/UWP/PPSSPP_UWPMain.h b/UWP/PPSSPP_UWPMain.h
@@ -20,7 +20,6 @@ class UWPGraphicsContext : public GraphicsContext {
 
 	void Shutdown() override;
 	void SwapInterval(int interval) override {}
-	void SwapBuffers() override {}
 	void Resize() override {}
 	Draw::DrawContext * GetDrawContext() override {
 		return draw_;

diff --git a/Windows/GPU/D3D11Context.h b/Windows/GPU/D3D11Context.h
@@ -31,7 +31,6 @@ class D3D11Context : public WindowsGraphicsContext {
 	bool Init(HINSTANCE hInst, HWND window, std::string *error_message) override;
 	void Shutdown() override;
 	void SwapInterval(int interval) override;
-	void SwapBuffers() override {}
 
 	void Resize() override;
 

diff --git a/Windows/GPU/D3D9Context.h b/Windows/GPU/D3D9Context.h
@@ -35,7 +35,6 @@ class D3D9Context : public WindowsGraphicsContext {
 	bool Init(HINSTANCE hInst, HWND window, std::string *error_message) override;
 	void Shutdown() override;
 	void SwapInterval(int interval) override;
-	void SwapBuffers() override {}
 
 	void Resize() override;
 

diff --git a/Windows/GPU/WindowsGLContext.cpp b/Windows/GPU/WindowsGLContext.cpp
@@ -39,7 +39,7 @@
 // Currently, just compile time for debugging.  May be NVIDIA only.
 static const int simulateGLES = false;
 
-void WindowsGLContext::SwapBuffers() {
+void WindowsGLContext::Poll() {
 	// We no longer call RenderManager::Swap here, it's handled by the render thread, which
 	// we're not on here.
 

diff --git a/Windows/GPU/WindowsGLContext.h b/Windows/GPU/WindowsGLContext.h
@@ -18,7 +18,8 @@ class WindowsGLContext : public WindowsGraphicsContext {
 
 	void Shutdown() override;
 	void SwapInterval(int interval) override;
-	void SwapBuffers() override;
+
+	void Poll() override;
 
 	// Used during window resize. Must be called from the window thread,
 	// not the rendering thread or CPU thread.

diff --git a/Windows/GPU/WindowsGraphicsContext.h b/Windows/GPU/WindowsGraphicsContext.h
@@ -7,4 +7,3 @@ class WindowsGraphicsContext : public GraphicsContext {
 public:
 	virtual bool Init(HINSTANCE hInst, HWND window, std::string *error_message) = 0;
 };
-
diff --git a/Windows/GPU/WindowsVulkanContext.h b/Windows/GPU/WindowsVulkanContext.h
@@ -30,7 +30,6 @@ class WindowsVulkanContext : public WindowsGraphicsContext {
 	bool Init(HINSTANCE hInst, HWND window, std::string *error_message) override;
 	void Shutdown() override;
 	void SwapInterval(int interval) override {}
-	void SwapBuffers() override {}
 	void Resize() override;
 	void Poll() override;
 

diff --git a/android/jni/AndroidJavaGLContext.h b/android/jni/AndroidJavaGLContext.h
@@ -15,7 +15,6 @@ class AndroidJavaEGLGraphicsContext : public AndroidGraphicsContext {
 	void ShutdownFromRenderThread() override;
 
 	void Shutdown() override {}
-	void SwapBuffers() override {}
 	void SwapInterval(int interval) override {}
 	void Resize() override {}
 

diff --git a/android/jni/AndroidVulkanContext.h b/android/jni/AndroidVulkanContext.h
@@ -16,7 +16,6 @@ class AndroidVulkanContext : public AndroidGraphicsContext {
 
 	void Shutdown() override;
 	void SwapInterval(int interval) override;
-	void SwapBuffers() override {}
 	void Resize() override;
 
 	void *GetAPIContext() override { return g_Vulkan; }

diff --git a/headless/SDLHeadlessHost.cpp b/headless/SDLHeadlessHost.cpp
@@ -96,7 +96,6 @@ class GLDummyGraphicsContext : public GraphicsContext {
 	void Shutdown() override {}
 	void Resize() override {}
 	void SwapInterval(int interval) override {}
-	void SwapBuffers() override {}
 
 private:
 	Draw::DrawContext *draw_ = nullptr;
@@ -193,7 +192,6 @@ bool SDLHeadlessHost::InitGraphics(std::string *error_message, GraphicsContext *
 			if (!gfx_->ThreadFrame()) {
 				break;
 			}
-			gfx_->SwapBuffers();
 		}
 
 		threadState_ = RenderThreadState::STOPPING;
@@ -221,7 +219,6 @@ void SDLHeadlessHost::ShutdownGraphics() {
 }
 
 void SDLHeadlessHost::SwapBuffers() {
-	gfx_->SwapBuffers();
 }
 
 #endif
diff --git a/headless/WindowsHeadlessHost.cpp b/headless/WindowsHeadlessHost.cpp
@@ -132,7 +132,6 @@ bool WindowsHeadlessHost::InitGraphics(std::string *error_message, GraphicsConte
 				if (!gfx_->ThreadFrame()) {
 					break;
 				}
-				gfx_->SwapBuffers();
 			}
 
 			threadState_ = RenderThreadState::STOPPING;
@@ -173,5 +172,4 @@ void WindowsHeadlessHost::SwapBuffers() {
 		TranslateMessage(&msg);
 		DispatchMessage(&msg);
 	}
-	gfx_->SwapBuffers();
 }
diff --git a/ios/ViewController.mm b/ios/ViewController.mm
@@ -64,7 +64,6 @@
 	}
 
 	void SwapInterval(int interval) override {}
-	void SwapBuffers() override {}
 	void Resize() override {}
 	void Shutdown() override {}
 

diff --git a/libretro/LibretroGraphicsContext.h b/libretro/LibretroGraphicsContext.h
@@ -22,6 +22,7 @@ class LibretroGraphicsContext : public GraphicsContext {
 		DestroyDrawContext();
 	}
 	void SwapInterval(int interval) override {}
+   virtual void SwapBuffers() = 0;
 	void Resize() override {}
 
 	virtual void GotBackbuffer();

diff --git a/libretro/libretro.cpp b/libretro/libretro.cpp
@@ -1174,7 +1174,7 @@ namespace Libretro
 
       if (ctx->GetDrawContext()) {
          ctx->GetDrawContext()->EndFrame();
-         ctx->GetDrawContext()->Present();
+         ctx->GetDrawContext()->Present(1);
       }
    }