Minor cleanup, add a speculative comment.

hrydgard · May 4, 2023 · 4e732af · 4e732af
1 parent c085990
commit 4e732af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Core/HLE/sceKernel.h b/Core/HLE/sceKernel.h
@@ -444,10 +444,10 @@ class KernelObjectPool {
 	u32 Destroy(SceUID handle) {
 		u32 error;
 		if (Get<T>(handle, error)) {
-			occupied[handle-handleOffset] = false;
-			delete pool[handle-handleOffset];
-			// Why weren't we zeroing before?
-			pool[handle-handleOffset] = nullptr;
+			int index = handle - handleOffset;
+			occupied[index] = false;
+			delete pool[index];
+			pool[index] = nullptr;
 		}
 		return error;
 	};

diff --git a/Core/MIPS/JitCommon/JitCommon.cpp b/Core/MIPS/JitCommon/JitCommon.cpp
@@ -54,6 +54,8 @@ namespace MIPSComp {
 	std::recursive_mutex jitLock;
 
 	void JitAt() {
+		// TODO: We could probably check for a bad pc here, and fire an exception. Could spare us from some crashes.
+		// Although, we just tried to load from this address to check for a JIT block, and if we're here, that succeeded..
 		jit->Compile(currentMIPS->pc);
 	}