Change TODO to a better idea

hrydgard · May 4, 2023 · 7ddcf62 · 7ddcf62
1 parent 3148a8a
commit 7ddcf62
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/GPU/GPUCommonHW.cpp b/GPU/GPUCommonHW.cpp
@@ -806,7 +806,6 @@ void GPUCommonHW::FastRunLoop(DisplayList &list) {
 			if (info.flags & FLAG_EXECUTE) {
 				downcount = dc;
 				(this->*info.func)(op, diff);
-				// TODO: Check pc here, and break if invalid, as the func can change it. Might an have a performance impact though.
 				dc = downcount;
 			}
 		} else {
@@ -820,7 +819,6 @@ void GPUCommonHW::FastRunLoop(DisplayList &list) {
 			if (flags & (FLAG_EXECUTE | FLAG_EXECUTEONCHANGE)) {
 				downcount = dc;
 				(this->*info.func)(op, diff);
-				// TODO: Check pc here, and break if invalid, as the func can change it. Might have a performance impact though.
 				dc = downcount;
 			} else {
 				uint64_t dirty = flags >> 8;

diff --git a/GPU/GPUCommonHW.h b/GPU/GPUCommonHW.h
@@ -62,6 +62,7 @@ class GPUCommonHW : public GPUCommon {
 
 	void Execute_TexFlush(u32 op, u32 diff);
 
+	// TODO: Have these return an error code if they jump to a bad address. If bad, stop the FastRunLoop.
 	typedef void (GPUCommonHW::*CmdFunc)(u32 op, u32 diff);
 
 	void FastRunLoop(DisplayList &list) override;