Skip to content

Commit

Permalink
Redump checks: Disable negativem messages
Browse files Browse the repository at this point in the history
The current database has issues as mentioned in #18387. Until this is
resolved and until we have confidence in the DB, don't be so loud
about ISOs possibly being bad.
  • Loading branch information
hrydgard committed Oct 30, 2023
1 parent 8ce639f commit 9745995
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions UI/GameScreen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -321,27 +321,28 @@ void GameScreen::render() {
found = true;
}
}
tvVerified_->SetVisibility(UI::V_VISIBLE);
if (found) {
tvVerified_->SetText(ga->T("ISO OK according to the Redump project"));
tvVerified_->SetLevel(NoticeLevel::SUCCESS);
tvVerified_->SetVisibility(UI::V_VISIBLE);
} else {
tvVerified_->SetText(ga->T("CRC checksum does not match, bad or modified ISO"));
tvVerified_->SetLevel(NoticeLevel::ERROR);
// Like the other messages below, disabled until we have a database we have confidence in.
// tvVerified_->SetText(ga->T("CRC checksum does not match, bad or modified ISO"));
// tvVerified_->SetLevel(NoticeLevel::ERROR);
}
} else {
tvVerified_->SetText(ga->T("Game ID unknown - not in the Redump database"));
tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::WARN);
// tvVerified_->SetText(ga->T("Game ID unknown - not in the Redump database"));
// tvVerified_->SetVisibility(UI::V_VISIBLE);
// tvVerified_->SetLevel(NoticeLevel::WARN);
}
} else if (!isHomebrew_) {
GameDBInfo dbInfo;
if (tvVerified_) {
std::vector<GameDBInfo> dbInfos;
if (!g_gameDB.GetGameInfos(info->id_version, &dbInfos)) {
tvVerified_->SetText(ga->T("Game ID unknown - not in the ReDump database"));
tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::WARN);
// tvVerified_->SetText(ga->T("Game ID unknown - not in the ReDump database"));
// tvVerified_->SetVisibility(UI::V_VISIBLE);
// tvVerified_->SetLevel(NoticeLevel::WARN);
} else if (info->gameSizeUncompressed != 0) { // don't do this check if info still pending
bool found = false;
for (auto &dbInfo : dbInfos) {
Expand All @@ -351,9 +352,9 @@ void GameScreen::render() {
}
}
if (!found) {
tvVerified_->SetText(ga->T("File size incorrect, bad or modified ISO"));
tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::ERROR);
// tvVerified_->SetText(ga->T("File size incorrect, bad or modified ISO"));
// tvVerified_->SetVisibility(UI::V_VISIBLE);
// tvVerified_->SetLevel(NoticeLevel::ERROR);
} else {
tvVerified_->SetText(ga->T("Click \"Calculate CRC\" to verify ISO"));
tvVerified_->SetVisibility(UI::V_VISIBLE);
Expand Down

0 comments on commit 9745995

Please sign in to comment.