Merge pull request #17457 from unknownbrackets/zip-install

UI: Fix thread error on zip open failure
hrydgard · May 14, 2023 · c8b5871 · c8b5871
2 parents 55c1c48 + 252d71f
commit c8b5871
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Core/Util/GameManager.cpp b/Core/Util/GameManager.cpp
@@ -310,7 +310,7 @@ bool GameManager::InstallGame(Path url, Path fileName, bool deleteAfter) {
 
 	struct zip *z = ZipOpenPath(fileName);
 	if (!z) {
-		installInProgress_ = false;
+		SetInstallError(sy->T("Unable to open zip file"));
 		return false;
 	}
 
@@ -742,6 +742,6 @@ void GameManager::ResetInstallError() {
 }
 
 void GameManager::InstallDone() {
-	installInProgress_ = false;
 	installDonePending_ = true;
+	installInProgress_ = false;
 }