Skip to content

Commit

Permalink
Change when we call rc_client_do_frame to something that matches libr…
Browse files Browse the repository at this point in the history
…etro

There's conflicting advice on when to do it, but to avoid people testing
their cheats twice, let's match as closely as we can.

This means that 30hz games will only have the callback run at 30hz.

The duplicate frames option may interfere, just like it may on libretro.
  • Loading branch information
hrydgard committed Jan 22, 2024
1 parent 9fdcef9 commit ec411e0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Core/HLE/sceDisplay.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,6 @@ static void DoFrameIdleTiming() {
void hleEnterVblank(u64 userdata, int cyclesLate) {
int vbCount = userdata;

// This should be a good place to do it. Should happen once per vblank. Here or in leave? Not sure it matters much.
Achievements::FrameUpdate();

VERBOSE_LOG(SCEDISPLAY, "Enter VBlank %i", vbCount);

DisplayFireVblankStart();
Expand Down
3 changes: 3 additions & 0 deletions UI/EmuScreen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,9 @@ ScreenRenderFlags EmuScreen::render(ScreenRenderMode mode) {
}

PSP_EndHostFrame();

// This place rougly matches how libretro handles it (after retro_frame).
Achievements::FrameUpdate();
}


Expand Down

0 comments on commit ec411e0

Please sign in to comment.