GameInfoCache: Check read size before using the data.

hrydgard · Jan 25, 2024 · f0af76e · f0af76e
1 parent 039fb86
commit f0af76e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/UI/GameInfoCache.cpp b/UI/GameInfoCache.cpp
@@ -351,15 +351,20 @@ static bool ReadFileToString(IFileSystem *fs, const char *filename, std::string
 	if (mtx) {
 		std::string data;
 		data.resize(info.size);
-		fs->ReadFile(handle, (u8 *)data.data(), info.size);
+		size_t readSize = fs->ReadFile(handle, (u8 *)data.data(), info.size);
 		fs->CloseFile(handle);
-
+		if (readSize != info.size) {
+			return false;
+		}
 		std::lock_guard<std::mutex> lock(*mtx);
 		*contents = std::move(data);
 	} else {
 		contents->resize(info.size);
-		fs->ReadFile(handle, (u8 *)contents->data(), info.size);
+		size_t readSize = fs->ReadFile(handle, (u8 *)contents->data(), info.size);
 		fs->CloseFile(handle);
+		if (readSize != info.size) {
+			return false;
+		}
 	}
 	return true;
 }