Implement vertex range culling #11393

unknownbrackets · 2018-09-17T05:56:00Z

Based on tests, skips triangles with any point outside the 4096x4096 box, except when depth clamping would engage. Does not actually implement depth clamp, just implements the culling rules related to it.

Alternative to (and heavily inspired by) #9527 and currently GLES only seeking feedback and tests in more games. This at least fixes the Brave Story triangle (#8251) so far, but I don't have all the affected racing games to confirm.

If this seems right, can port it to the other backends for merge.

Fixes #9527, fixes #8251, fixes #5001, fixes #10928, fixes #11260, may help #2159, #5507, #7026, and #7294.

-[Unknown]

unknownbrackets · 2018-09-17T06:04:21Z

I guess we could maybe use this on some devices?
https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_clip_cull_distance.txt

Also wonder if I should add a hidden ini-only setting in case this causes issues or performance problems...

-[Unknown]

hrydgard · 2018-09-17T09:21:31Z

So the cull distance extension specifies how far behind a clipping plane a single vertex is? That means that to kill a whole triangle from the context of a single vertex, you'll have to set it to a very large number (and you still might get stray pixels from the other two verts? Though probably not much of an issue in this case).

hrydgard · 2018-09-17T09:29:37Z

Tagged this for 1.8.0, depending on how it goes might un-bump to 1.7.0.

marosis · 2018-09-17T10:09:59Z

@hrydgard😥

hrydgard · 2018-09-17T11:06:47Z

What? It's not finished. No need for the sadface.

Based on tests, skips triangles with any point outside the 4096x4096 box, except when depth clamping would engage.

Also D3D11, since they are very similar.

unknownbrackets · 2018-09-17T14:28:00Z

I tried setting gl_ClipDistance[0] to a very negative number, and glEnable(GL_CLIP_DISTANCE0);, but doesn't clip anything. Not sure what I'm missing... no errors.

Well, maybe we stick with the w approach. Anyway, I went ahead and ported this to the other backends.

-[Unknown]

hrydgard · 2018-09-17T18:29:24Z

Looking very good so far, though I don't have all the affected games either. Unlike my old change it doesn't break Wipeout subtly in the corners.

It doesn't seem to have any bad effect that I can see, but I haven't tested on many devices yet. If there are issues, as mentioned we can just whitelist it per game...

unknownbrackets · 2018-09-18T01:44:23Z

Vulkan depth clamp is interacting poorly with this on #11260 - of the two examples, one isn't fixed still, and it's only not fixed when Vulkan's depthClampEnable is true. On all other backends, it's fixed by this pull.

I'm not sure why - presumably depth clamping happens right before depth testing, after the vertex shader? I didn't find any obvious definition of this for Vulkan. In that case, it would imply depth clamping is sometimes breaking the w = NAN thing.

-[Unknown]

Vulkan clamps to the clip range, not the full range. So when clipping, we don't really want to clamp at all. Unfortunately, when one side is clipping, we can't do it exactly right. But many games clip depth, like Dissidia. Fixes hrydgard#11260.

unknownbrackets · 2018-09-18T04:53:46Z

Added a depth clamping improvement, see #11399 for more details (there's still a less common scenario that is wrong.) Now #11260 is fixed.

-[Unknown]

hrydgard · 2018-09-18T10:08:47Z

Thanks. I'll run through a whole bunch of games soon and then probably merge. Seems safe enough nw (and easy enough to disable in case of problems).

The Vulkan clamping behavior is a bit unfortunate, yeah..

hrydgard · 2018-09-18T21:21:39Z

Let's try it.

marosis · 2018-09-19T02:34:13Z

I will test some games and write if they are fixed

marosis · 2018-09-19T02:53:11Z

Btw please can you answer me why are android builds minimaly? I see only for Windows platform on PPSSPP builds website

unknownbrackets · 2018-09-19T04:22:19Z

There was an issue with cmake - fixed in 1f881d7.

-[Unknown]

ghost · 2018-09-19T05:01:11Z

Hellboy The Science Of Evil

YuGiOh Arc V tag force special

ghost · 2018-09-19T05:02:57Z

Tekken 6

ghost · 2018-09-19T05:04:48Z

Phone Specs:
OpenGL 2.0
Mali-450 MP
Octacore
2GB ram
PPSSPP use Build 1.6 3-483g1f881d790

unknownbrackets · 2018-09-19T07:17:43Z

Maybe we ran out of vertex shader registers... ugh. Might have to blacklist cullrange on Mali-4xx.

-[Unknown]

marosis · 2018-09-19T08:26:50Z

Ohhhh. Aaaaaand problems are starting😂😂😂

unknownbrackets · 2018-09-21T01:23:20Z

Maybe we could use gl_extensions.gpuVendor == GPU_VENDOR_ARM && strstr(gl_extensions.model, "Mali-4") && !gl_extensions.VersionGEThan(3, 0) to set a bug flag, and blacklist on Mali 4xx, but I don't have enough devices to validate that it fixes it...

-[Unknown]

unknownbrackets · 2018-09-21T04:18:01Z

Or maybe those games are using large viewports, should try after #11407.

-[Unknown]

ghost · 2018-09-21T05:24:03Z

I have found a weird solution for this issue in my Mali-450 GPU using GLtools (not advisable) since my phone is rooted I just enable Optimize GLSL shader in the menu and then boom its fixed the issue.

ghost · 2018-09-21T05:25:25Z

Tekken 6 now are OK and other my ppsspp game also its improved the performance just a little bit.

*sorry for my bad english 😅

unknownbrackets · 2018-09-21T07:02:11Z

Hmm, I wonder if we should try running a glsl->spirv->opt->glsl pass on the shaders...

-[Unknown]

hrydgard · 2018-09-21T07:15:59Z

Hm. They have so little confidence in the driver optimizer that they hide it behind an option?

But yeah, that would be interesting to try.

ghost · 2018-09-21T11:35:08Z

PPSSPP Build v1.6.3-492-g9fddfff66 didn't helped the issue :(

marosis · 2018-09-21T17:17:57Z

DTM race driver-still same issue

unknownbrackets added the Guardband / Range Culling Involves vertices outside fustrum. label Sep 17, 2018

hrydgard added this to the v1.8.0 milestone Sep 17, 2018

unknownbrackets added 3 commits September 17, 2018 07:27

GLES: Implement vertex range culling.

ab3a466

Based on tests, skips triangles with any point outside the 4096x4096 box, except when depth clamping would engage.

D3D9: Implement vertex range culling.

639a3f4

Vulkan: Implement verex range culling.

44ba31f

Also D3D11, since they are very similar.

unknownbrackets force-pushed the cullrange branch from 551cdd8 to 44ba31f Compare September 17, 2018 14:27

hrydgard modified the milestones: v1.8.0, v1.7.0 Sep 17, 2018

unknownbrackets changed the title ~~WIP - GLES: Implement vertex range culling~~ Implement vertex range culling Sep 18, 2018

unknownbrackets mentioned this pull request Sep 18, 2018

D3D11 and Vulkan depth clamp incorrectly without clip distance or geometry shading support #11399

Open

GPU: Refactor cull range calculation together.

52baec2

hrydgard merged commit acfd688 into hrydgard:master Sep 18, 2018

unknownbrackets deleted the cullrange branch September 18, 2018 22:20

This was referenced Sep 19, 2018

Missing background : Romance Of Three Kingdom 9 PK #2159

Closed

Outrun 2006: Various tracks have graphical issues (black/missing geometry) #5507

Closed

This was referenced Sep 19, 2018

Driver 76 lines bug #7026

Closed

V8 Supercars 3 Shootout artifacts issue #7294

Closed

D3D11: Enable depth clamping #11402

Merged

This was referenced Sep 22, 2018

Consider auto-optimizing shaders #11412

Closed

DTM Race Driver 3; Toca 2 Graphic Problems #5001

Closed

ghost mentioned this pull request Sep 23, 2018

Latest build cannot be opened #11404

Closed

unknownbrackets mentioned this pull request Oct 19, 2018

Direct3D 9 does not display images of 3D games #11477

Closed

teorex3 mentioned this pull request Dec 4, 2018

Direct3D 9 does not display images of 3D games on Nvidia GPU #11638

Closed

ghost mentioned this pull request Dec 9, 2018

Monster Hunter Portable 3rd Graphical issue #11635

Closed

xebra mentioned this pull request Dec 23, 2018

Bezier low-quality graphics glitch is caused by Vertex Range Culling. #11692

Closed

hrydgard mentioned this pull request Aug 9, 2019

Vulkan/GL: Set all four coordinates to NaN instead of just W. #12227

Merged

Davidcard22 mentioned this pull request Jan 14, 2021

phantasy star portable 2 infinity - strange framerate drops #13914

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement vertex range culling #11393

Implement vertex range culling #11393

unknownbrackets commented Sep 17, 2018 •

edited

Loading

unknownbrackets commented Sep 17, 2018

hrydgard commented Sep 17, 2018

hrydgard commented Sep 17, 2018 •

edited

Loading

marosis commented Sep 17, 2018

hrydgard commented Sep 17, 2018

unknownbrackets commented Sep 17, 2018

hrydgard commented Sep 17, 2018

unknownbrackets commented Sep 18, 2018

unknownbrackets commented Sep 18, 2018

hrydgard commented Sep 18, 2018

hrydgard commented Sep 18, 2018

marosis commented Sep 19, 2018 •

edited

Loading

marosis commented Sep 19, 2018

unknownbrackets commented Sep 19, 2018

ghost commented Sep 19, 2018

ghost commented Sep 19, 2018 •

edited by ghost

Loading

ghost commented Sep 19, 2018 •

edited by ghost

Loading

unknownbrackets commented Sep 19, 2018

marosis commented Sep 19, 2018

unknownbrackets commented Sep 21, 2018

unknownbrackets commented Sep 21, 2018

ghost commented Sep 21, 2018 •

edited by ghost

Loading

ghost commented Sep 21, 2018 •

edited by ghost

Loading

unknownbrackets commented Sep 21, 2018

hrydgard commented Sep 21, 2018

ghost commented Sep 21, 2018 •

edited by ghost

Loading

marosis commented Sep 21, 2018

Implement vertex range culling #11393

Implement vertex range culling #11393

Conversation

unknownbrackets commented Sep 17, 2018 • edited Loading

unknownbrackets commented Sep 17, 2018

hrydgard commented Sep 17, 2018

hrydgard commented Sep 17, 2018 • edited Loading

marosis commented Sep 17, 2018

hrydgard commented Sep 17, 2018

unknownbrackets commented Sep 17, 2018

hrydgard commented Sep 17, 2018

unknownbrackets commented Sep 18, 2018

unknownbrackets commented Sep 18, 2018

hrydgard commented Sep 18, 2018

hrydgard commented Sep 18, 2018

marosis commented Sep 19, 2018 • edited Loading

marosis commented Sep 19, 2018

unknownbrackets commented Sep 19, 2018

ghost commented Sep 19, 2018

ghost commented Sep 19, 2018 • edited by ghost Loading

ghost commented Sep 19, 2018 • edited by ghost Loading

unknownbrackets commented Sep 19, 2018

marosis commented Sep 19, 2018

unknownbrackets commented Sep 21, 2018

unknownbrackets commented Sep 21, 2018

ghost commented Sep 21, 2018 • edited by ghost Loading

ghost commented Sep 21, 2018 • edited by ghost Loading

unknownbrackets commented Sep 21, 2018

hrydgard commented Sep 21, 2018

ghost commented Sep 21, 2018 • edited by ghost Loading

marosis commented Sep 21, 2018

unknownbrackets commented Sep 17, 2018 •

edited

Loading

hrydgard commented Sep 17, 2018 •

edited

Loading

marosis commented Sep 19, 2018 •

edited

Loading

ghost commented Sep 19, 2018 •

edited by ghost

Loading

ghost commented Sep 19, 2018 •

edited by ghost

Loading

ghost commented Sep 21, 2018 •

edited by ghost

Loading

ghost commented Sep 21, 2018 •

edited by ghost

Loading

ghost commented Sep 21, 2018 •

edited by ghost

Loading