Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle libSDL inside app on macOS, fixes #11830 #11831

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Bundle libSDL inside app on macOS, fixes #11830 #11831

merged 1 commit into from
Feb 23, 2019

Conversation

vit9696
Copy link
Contributor

@vit9696 vit9696 commented Feb 23, 2019

No description provided.

unknownbrackets
unknownbrackets approved these changes Feb 23, 2019
View reviewed changes
Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, we bundle redists on Windows too. libzip isn't a problem, right (page says to install libzip too)?

-[Unknown]

@vit9696
Copy link
Contributor Author

vit9696 commented Feb 23, 2019

Static one is used in my case, as I did not install it and did not provide USE_SYSTEM_LIBZIP=1.

@hrydgard hrydgard merged commit 4c83d30 into hrydgard:master Feb 23, 2019
@unknownbrackets unknownbrackets added this to the v1.8.0 milestone Feb 23, 2019
@unknownbrackets unknownbrackets mentioned this pull request Mar 2, 2019
Merged
@unknownbrackets unknownbrackets mentioned this pull request Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknownbrackets unknownbrackets unknownbrackets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vit9696 @unknownbrackets @hrydgard