Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan/GL: Set all four coordinates to NaN instead of just W. #12227

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 8, 2019

Fixes range culling on ARM Mali. Fixes #11999.

Could make this vendor specific, but I think this will reliably kill the triangle on all archs...

@hrydgard hrydgard added Vulkan Guardband / Range Culling Involves vertices outside fustrum. labels Aug 8, 2019
@hrydgard hrydgard added this to the v1.9.0 milestone Aug 8, 2019
@hrydgard hrydgard changed the title Vulkan: Set all four coordinates to NaN instead of just W. Vulkan/GL: Set all four coordinates to NaN instead of just W. Aug 8, 2019
@hrydgard hrydgard merged commit 3b4e371 into master Aug 8, 2019
@hrydgard hrydgard deleted the range-cull-aggressive branch August 8, 2019 22:09
@unknownbrackets
Copy link
Collaborator

Nice.

-[Unknown]

@marosis
Copy link

marosis commented Aug 9, 2019

Mali T-720 confirmed
Screenshot_2019-08-09-13-21-30

@Deivmsr
Copy link

Deivmsr commented Aug 9, 2019

This seems to have solved the graphics problem in Driver 76 which is now playable. In GL and Vulkan.
Screenshot_20190809-073749_PPSSPP
Screenshot_20190809-073655_PPSSPP

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 9, 2019

Yeah, this is expected to fix all the stuff that was fixed by #11393 on non-Mali platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guardband / Range Culling Involves vertices outside fustrum. Vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardband glitchfix not enabled on Mali G71 (Toca Race driver 2, others)
4 participants