Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Graphic]Draslot Syuyaku wa Zenigata(ULJM05014) ドラスロット 主役は銭形 #12507

Closed
nassau-tk opened this issue Dec 12, 2019 · 5 comments · Fixed by #12750
Closed
Labels
Milestone

Comments

@nassau-tk
Copy link
Contributor

What happens?

This game is a slot machine game.
When a steel case of a slot machine is OpenGL, a problem don't be drawn right.
It's drawn right at the time of Vulkan use.

What should happen?

Even OpenGL is drawn right.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

PPSSPP Ver. : 1.9.3-147
OS: Android 9.0
DeviceName: SONY SO-02K / Xperia XZ1 Compact (Japan)
CPU: Snapdragon835 (Octa-core)
GPU: Adreno 540
Resolution: 720×1280
RAM: 4GB
ROM:32GB
ExternalStrage: microSDXC 512GB

Please check the screenshot.

Screenshot_20191212-161510

Screenshot_20191212-161621

@hrydgard
Copy link
Owner

That's interesting! Can you make a GE frame capture? https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

@hrydgard hrydgard added this to the v1.10.0 milestone Dec 12, 2019
@nassau-tk
Copy link
Contributor Author

It was a very difficult request, but I think it's probably done. (^o^)/
Please check it!!

ULJM05014_GEdump.zip

@iota97
Copy link
Contributor

iota97 commented Dec 12, 2019

Shouldn't the label be OpenGL? It look like Vulkan render fine while OpenGL is broken from the screenshot.

@hrydgard
Copy link
Owner

Oh, indeed, oops! Thanks for making the frame capture nassau!

@hrydgard hrydgard added OpenGL and removed Vulkan labels Dec 12, 2019
@unknownbrackets
Copy link
Collaborator

The specular coef is 00ff2626 / -220849154580920358351916130867047563264. This seems to cause it to use full white. Essentially, this makes the specular factor Infinity.

When I skip the specular, things look right. Even if I cap it, it doesn't look like it's supposed to - here's a PSP's rendering:
ULJM05014_#12507_draslot_metal_rendering

It seems infinity should be treated as zero, but will probably need to figure out where the limit is that the hardware kills it...

-[Unknown]

@unknownbrackets unknownbrackets added the Needs hardware testing Testing on a real device needed to determine correct behavior. label Jan 2, 2020
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Mar 23, 2020
Based on hrydgard#12507 and some tests, seems like negative exponents are also
fixed to a 1.0f result.
@unknownbrackets unknownbrackets removed the Needs hardware testing Testing on a real device needed to determine correct behavior. label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants