Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove frameskipping fast-forward #13546

Closed
hrydgard opened this issue Oct 14, 2020 · 4 comments · Fixed by #14857
Closed

Should remove frameskipping fast-forward #13546

hrydgard opened this issue Oct 14, 2020 · 4 comments · Fixed by #14857
Milestone

Comments

@hrydgard
Copy link
Owner

It just causes too much breakage, like for example #6243 (comment) .

Instead we need to use the render-multiple-frames-in-one-frame, or dynamically turn off vsync, on all platforms (currently on Android we only use frameskipping fast-forward).

@hrydgard hrydgard added this to the v1.11.0 milestone Oct 14, 2020
@hrydgard hrydgard changed the title Remove frameskipping fast-forward Should remove frameskipping fast-forward Oct 14, 2020
@Panderner
Copy link
Contributor

it does it happens for unskippable laggy cutscenes for some games running on Lower powered devices?

@hrydgard
Copy link
Owner Author

I don't think it'll be much of a concern. Yes it might take slightly longer to get past some annoying cutscenes on slower devices...

Alternatively, just we can change it so it's not the default, it'll still be an option.

@unknownbrackets
Copy link
Collaborator

I do think we should keep doing the frameskip thing (which might just happen) if you have frameskip enabled. But definitely prefer not to frameskip with it off - that's easier to explain as a speedhack.

I'm not sure it really needs to be a separate visible option imho.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

The default is changed. I think we'd remove if all goes well in v1.13.0.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants