Debugger: Avoid mem write tag lookup on small alloc #15377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually there won't be any breakpoints, so it makes sense to enable detail when they're added automatically.
|
That's a neat solution to keep the memchecks working if any. Nice! |
hrydgard
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically wraps every case of
GetMemWriteTagAt()in a check to make sure the size is large enough that we'll use the result.We do check that for video uploads, but only for larger sizes anyway, so there should be no change there.
Because this would break memory breakpoints alone, I also made adding a memory breakpoint automatically enable detailed memory info for the lifetime of the breakpoint. It makes sense, because you want the greater detail and it'll already be slower in jit, etc.
See #15251.
-[Unknown]