Remaining rendering problems in Tantalus games

[hrydgard]

Now that the main issues of #15898 have been fixed in #15907, Cars and the MX vs ATV games are playable and render okay at 1x. Spongebob is near perfect, the depth swizzle just needs improvement for higher resolution to get sharp edges against the sky.

There are still issues though:

• In games other than Spongebob, the sky seems 1 pixel off even in 1x, leading to some weird fringes (also, in new builds, Cars specifically is too dark):
  
• Vertical stripes at 2x or higher resolutions
  
• Performance improvments are possible - we're not always making good use of load/store on renderpasses, and reinterpret can often be limited to smaller rectangles, at least in theory.

[Panderner]

MX vs. ATV Reflex still has a issue:

[hrydgard]

Which api and hardware?

[ghost]

Vulkan and OpenGL.
MX vs ATV Untamed X2 Reso.

Vulkan/OpenGL
SpongeBob SquarePants.

Software is glitchy

BTW thanks for improving this long standing issue.

[ghost]

There's a bug in hack setting lower resolution for effects for MX vs ATV Untamed.

[Panderner]

Here's a screenshots using Direct3d 9:

[hrydgard]

c75b023 fixes the problem you reported in MX vs ATV @Panderner .

[ghost]

Car's O Rama and MX vs ATV graphics is broken again.

ppsspp v1.13.2-947 x1 Resolution both happen in opengl and vulkan.

[hrydgard]

Thanks, I'll fix it up.

somehow, the culprit is 39890f7

[hrydgard]

OK, fixed it up, back to the way it was.

[ghost]

Car's O Rama is darker now unlike before.Tested both opengl and vulkan backend.

Recently ppsspp build.

Your screenshot above.

[hrydgard]

Interesting, I'll have to look into that.

[Panderner]

And also MX vs. ATV Reflex:

[ppmeis]

Tested in latest build, Vulkan backend. Confirmed games are darker than before:

[hrydgard]

Hm, that's not expected. I'll try to look at it, but might not be until after 1.14.1, which I'll launch on Monday or Tuesday.

Seems to be some kind of automatic brightness adaptation, that didn't work before, and now malfunctions, heh.

[hrydgard]

Went ahead and did a bisect, the darkening behavior (it gradually darkens as you start the track) started in 92eaac0 , which also fixed some rather bad rendering issues.

So presumably there's a brightness adaptation effect that started working at that commit, but is not working completely correctly. Sigh, might be a tricky one.