Fix depal bounds with dynamic CLUT. Fixes lens flare glitches in Ridge Racer #16188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Oct 9, 2022
…e Racer With this wrong, we ended up drawing pixels that came from a DONT_CARE init of the depal temp buffer, which was a pile of garbage on Android and blank on PC. Now, we seem to end up not drawing anything because the depal operation results in transparent black into whatever is actually intended, but at least the screen isn't full of glitches when the sun is visible on Adreno. See issue #16083
hrydgard
force-pushed
the
ridge-racer-sun-flare
branch
from
ec1c88a
to
9422b05
Compare
hrydgard
added a commit
that referenced
this pull request
Oct 9, 2022
Followup to #16188 . Further fixes the lens flare. It confused me before that there are two sections of the track on Sunset Drive where the sun is visible, but only on the second is the lens flare sprite actually shown, which is rather weird. Verified that exactly the same thing happens on hardware, so it's not a glitch!
hrydgard
added a commit
that referenced
this pull request
Oct 9, 2022
Followup to #16188 . Further fixes the lens flare. It confused me before that there are two sections of the track on Sunset Drive where the sun is visible, but only on the second is the lens flare sprite actually shown, which is rather weird. Verified that exactly the same thing happens on hardware, so it's not a an emulation problem! Rather seems like a glitch in the game itself.
Nemoumbra
pushed a commit
to Nemoumbra/ppsspp
that referenced
this pull request
Oct 10, 2022
Followup to hrydgard#16188 . Further fixes the lens flare. It confused me before that there are two sections of the track on Sunset Drive where the sun is visible, but only on the second is the lens flare sprite actually shown, which is rather weird. Verified that exactly the same thing happens on hardware, so it's not a an emulation problem! Rather seems like a glitch in the game itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though doesn't fully fix the lens flare, see below and issue #16083.
With this wrong, we ended up drawing pixels that came from a DONT_CARE init of the depal temp buffer, which was a pile of garbage on Android and blank on PC.
Now, we seem to end up not drawing anything because the depal operation results in transparent black instead of whatever is actually intended, but at least the screen isn't full of glitches when the sun is visible on Adreno.