Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilt improvements: Add visualizer, better defaults #16889

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Feb 1, 2023

Helps #16881

Turns out it was nearly impossible to understand how tilt controls worked without a visualizer, so I added one.

And it was revealed that my understanding was wrong too (I didn't write the code originally), especially around calibration.

I'll followup with a change that will make it work better held at an angle. This will remove the Base Position setting and replace with just calibration.

Anyway, here's the first improvement to the UI, which already makes it much easier to configure:

image

@hrydgard hrydgard added Input/Controller Input and controller issues User Interface PPSSPP's own user interface / UX labels Feb 1, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Feb 1, 2023
@hrydgard hrydgard mentioned this pull request Feb 1, 2023
2 tasks
@iota97
Copy link
Contributor

iota97 commented Feb 1, 2023

There might be some minor issues with the translations, for example in Italian one:

Calibrate = Calibra il D-Pad
To Calibrate = Mantenere il dispositivo su una superficie piatta e premere "Calibra".

"To Calibrate" will ask to press "Calibra", but the button will actually be called "Calibra il D-Pad". Same with few other languages. Probably it's quite confusing it's referencing D-Pad here at all :/

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 1, 2023

It's not supposed to reference the D-Pad at all, dunno where that came from. I'll fix it.

assets/lang/ja_JP.ini Outdated Show resolved Hide resolved
assets/lang/lt-LT.ini Outdated Show resolved Hide resolved
assets/lang/tr_TR.ini Outdated Show resolved Hide resolved
assets/lang/uk_UA.ini Outdated Show resolved Hide resolved
assets/lang/ca_ES.ini Outdated Show resolved Hide resolved
@hrydgard hrydgard merged commit 738b7fc into master Feb 1, 2023
@hrydgard hrydgard deleted the tilt-improvements branch February 1, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants