Refactor the replacement cache #17134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in both unscaled and scaled dimensions
hrydgard
added
Code Cleanup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cache_now only contains minimal references, while ReplacedTexture now takes over the previous roles of thelevelCache_entries. Basically, we no longer create duplicateReplacedTexture, only duplicatedReplacedTextureRefthat point to the same ReplacedTexture.This makes things a lot more understandable and maintainable, mainly, there might also be some minor reduction in memory usage.
Additionally, this opens for the TextureCacheCommon to find out if multiple PSP texture get replaced with the same replaced texture and avoiding creating multiple host textures, but that's for later.
Additionally, this fixes enabling/disable texture replacement at runtime as a side effect.