Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running some file formats from the Downloads folder #17466

Merged
merged 2 commits into from
May 16, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented May 16, 2023

Due to how we mount stuff, we need to be able to navigate one step up from the executable, and then re-attach the executable filename. To allow this, in single-file (non-tree) content URIs, treat ':' as a directory separator for navigation purposes. Fixes #17462 in a way (see that issue for more information).

End result, you can now download cube.elf from the website and run it directly from Downloads without using a file manager to move it.

Seems to work just fine and fixes quite an annoying issue, so getting it in for 1.15.4.

Due to how we mount stuff, we need to be able to navigate one step up
from the executable, and then re-attach the executable filename. To
allow this, in content URIs, treat ':' as a directory separator for
navigation purposes.

End result, you can now download cube.elf from the website and run it directly
from Downloads without using a file manager to move it.
@hrydgard hrydgard added Platform-specific (Android) Scoped Storage Related to scoped storage on Android labels May 16, 2023
@hrydgard hrydgard added this to the v1.15.4 milestone May 16, 2023
@hrydgard hrydgard merged commit 6bdb721 into master May 16, 2023
@hrydgard hrydgard deleted the android-fix-load-from-downloads branch May 16, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform-specific (Android) Scoped Storage Related to scoped storage on Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Download folder files get the wrong filenames on Android 13
1 participant