SDL: text renderer fixes, and CI #17844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ALIGN_LEFT == 0, theif (align & ALIGN_LEFT)case is never hit. This leads to unintended text alignment sometimes... (See the homebrew description in screenshot)SDL_ttf pads the rendered text to the right a lot, which is the reason why in some buttons, you can see their labels getting pushed to the left. Fortunately though, the
text->wfield stores the exact width of the text we rendered, hence instead using an entire row of pixels, we use only the pixels right up totext->w(rounded up a little).Added dependencies sdl2_ttf and fontconfig to Linux CI.
Master:
PR:
