video shaking with UCAS40023 : 天地之門

[sum2012]

Inform by my qq freind x831120
The video have sound but black screen
PPSSPP v0.9.1-47-g89e476d log:
https://gist.github.com/sum2012/0a917748a57f9bf8ad7f

Update: Black screen has been fixed. Issue that remains is shaking video.

[unknownbrackets]

Has it ever played? Does it still continue after the video?

-[Unknown]

[sum2012]

Old version splash Screen .It still continue after the video.
My friend is finding that version.

[sum2012]

Last verision can see video is V0.8.1-1173
https://gist.github.com/sum2012/05ceca715fd9c4c2fef0
Splash screen shaking

[unknownbrackets]

v0.8.1-1173-ge03acc4...v0.8.1-1273-gfb6c2fa

To be clear, what's the first version that doesn't work?

Does it help to enable or disable the multithreading options? Or to disable buffered rendering, etc.?

-[Unknown]

[sum2012]

He only mean download able to test
I think it is a good time to teach me git bisect.
edit:Please note that I have made a pull request,do I need a clean source ?

[sum2012]

it don't help to enable or disable the multithreading options,Or to disable buffered rendering, etc.

[unknownbrackets]

For bisecting, you do normally want a clean source tree, yes.

It's pretty easy. Just start out in the directory and type:
git bisect start

Now compile, and test to see if it works. It probably won't assuming you're on master, so type:
git bisect bad

Now you need a new reference point. Let's use 1173:
git checkout e03acc4
(for this large a jump, it may be faster to close Visual Studio before that command, and reopen afterward. Otherwise Visual Studio will reload the project more slowly because the vcxproj files will change.)

Don't forget to update submodules since you moved:
git submodule update

Now again, compile and test. It should work this time so you'll say:
git bisect good

From here on it automatically picks a new revision (using the most optimal choices it can) to test next. Just keep answering it by compiling, and then using git bisect good, or git bisect bad. Don't forget to git submodule update before compiling each time.

If you run into a revision that can't be compiled, you can just skip it:
git bisect skip

In the worst case, if you have to skip a lot, git will give you a range of commits that could have been the cause. If you don't have to skip much, it should pinpoint the exact one.

-[Unknown]

[sum2012]

Thanks @unknownbrackets
Last work( video Splash screen shaking) v0.8.1-1202-g4d4b299
first broken (video black) is v0.8.1-1203-gca6de59

1202 log
https://gist.github.com/sum2012/df90f0733ea194d08195
1203 log
https://gist.github.com/sum2012/c51966c6a1e52ce4cff0

[sum2012]

The compare
v0.8.1-1202-g4d4b299...v0.8.1-1203-gca6de59
?

[unknownbrackets]

FWIW, added those instructions to the wiki for posterity:
https://github.com/hrydgard/ppsspp/wiki/How-to-bisect-to-find-what-broke-a-game

Yeah, looks like it's that commit: ca6de59. Frame timing is tricky business...

-[Unknown]

[sum2012]

Tested ppsspp-v0.9.1-1094-ge6ef262 see again the video
But still have Splash screen shaking video:
https://docs.google.com/file/d/0B3OaSdeV0L8kQmxZemprd3BmUTQ/edit?usp=sharing
Log:
https://gist.github.com/sum2012/79ed89d65196f46d7e15

[raven02]

I think we now back to the same as rev v0.8.1-1173 that able to show the video .Outstanding is video shaking issue that i think also happen in v0.8.1-1173

[sum2012]

@raven02 yes

[raven02]

If runs in other rendering mode , still the same shaking ?

[sum2012]

yes,still shaking

[raven02]

I see. thanks.

[xsacha]

Updated issue to reflect new issue.

[papel]

Does #4321 fix it?

[sum2012]

As I comment in #4248 (comment)
same black screen
v0.9.1-2172-g1507358 log:
https://gist.github.com/sum2012/a91ec2d616cb4fcf7072

[unknownbrackets]

Has this improved at all with the recent video improvements?

-[Unknown]

[sum2012]

v0.9.6-406-g62eb701
Now come back video shaking issue
info log:
https://gist.github.com/sum2012/97a26d3200308cc949d7
debug log:
https://drive.google.com/file/d/0B3OaSdeV0L8kdC0yb3RkZnQ0RDQ/edit?usp=sharing

[unknownbrackets]

Have any of the framebuffer, wrapping, block transfer, or other improvements helped?

-[Unknown]

[sum2012]

Where is wrapping option ?

[unknownbrackets]

It's not an option, it does it by default when it detects the framebuf size doesn't match the texture size.

-[Unknown]

[sum2012]

v0.9.8-1088-ga31194a same problem
debug log
https://drive.google.com/file/d/0B3OaSdeV0L8kUkpETzZuZFJjWGc/edit?usp=sharing

[unknownbrackets]

sceDisplaySetFramebuf(topaddr=0999fe40,linesize=512,pixelsize=3,sync=1)

Hmm. It decodes and displays directly from RAM. The values are pretty direct so not sure why it'd be offset.

-[Unknown]

[sum2012]

Test v0.9.9-37-g682e1c1
fixed
debug log
https://gist.github.com/sum2012/3be3cfc272a1c07a7430