Unsafe Slashes in ppsspp.ini

[tilkinsc]

Looking through some source files, I know how much you care about which way the slash goes on windows versus other platforms. While windows accepts forwards slashes, and the mixture of the two, I don't think something correct is happening here - in that it is way too volatile. FileName0 has a V. It much be much easier to convert the entire system to / instead of messing around with / and \ correctness. In fact, I use / almost always on windows. Fixing specific broken features would be easier on a per-problem basis.

FileName0 = C:\pspsdk\projects\file_io/bin/EBOOT.PBP
FileName1 = C:/Users/Bud/Desktop/ppsspp/memstick/PSP/GAME/bin
FileName2 = C:/Users/Bud/Desktop/ppsspp/memstick/PSP/GAME/test/EBOOT.PBP
FileName3 = C:\pspsdk\psp\sdk\samples\net\simple\EBOOT.PBP
FileName4 = C:\pspsdk\psp\sdk\samples\kernel\threadstatus\EBOOT.PBP
FileName5 = C:\pspsdk\psp\sdk\samples\kernel\systimer\EBOOT.PBP
FileName6 = C:\pspsdk\psp\sdk\samples\kernel\sysevent\EBOOT.PBP
FileName7 = C:/pspsdk/psp/sdk/samples/kernel/registry/EBOOT.PBP
FileName8 = C:\pspsdk\psp\sdk\samples\kernel\regenum\EBOOT.PBP
FileName9 = C:\pspsdk\psp\sdk\samples\kernel\messagebox\EBOOT.PBP
FileName10 = C:\pspsdk\psp\sdk\samples\kernel\loadmodule\EBOOT.PBP
FileName11 = C:\pspsdk\psp\sdk\samples\kernel\idstorage\EBOOT.PBP
FileName12 = C:\pspsdk\psp\sdk\samples\kernel\cwd\EBOOT.PBP
FileName13 = C:\pspsdk\psp\sdk\samples\kernel\fileio\EBOOT.PBP
FileName14 = C:\pspsdk\projects\user_input/bin/EBOOT.PBP < btw here is the UserInput tutorial
FileName15 = C:\pspsdk\projects\lua/bin/EBOOT.PBP
FileName16 = C:\pspsdk\projects\lua\bin/EBOOT.PBP
FileName17 = C:/pspsdk/projects/hello_world/bin/EBOOT.PBP

[hrydgard]

Hm, yeah, this would be the cause of duplicates showing up. Needs looking into

[hrydgard]

Alright, that should take care of it as you use it (no more backslashes will be added to the list).

Though, how are you starting the games so that the backslashes end up there? I tried both clicking game buttons and Load File and got forward slashes. Command line?

[tilkinsc]

I use the command line with an absolute path.

@echo off
TITLE Running EBOOT.PBP...

IF NOT EXIST bin/EBOOT.PBP (
	echo Failed to find EBOOT.PBP in bin!
	pause
	goto end
)

setlocal

call using %PSPToolchain% q

echo Running...

ppsspp.lnk "%~dp0/bin/EBOOT.PBP"

endlocal

echo Done.

:end

call using %PSPToolchain% q quietly inserts a temporary temporary addition to PATH. %~dp0 is the current working directory.

[tilkinsc]

Now that I think of it, %~dp0 could be the culprit because it will give the path in Windows slashes. The files loaded through PPSSPP gui is probably the only forward slashes.

One more thing, could you add an addition that makes it possible for relative paths to be used? I can only use absolute paths. I think a simple absolute path get of the loaded PBP using relative path is what is needed to do the checks and stuff you added with one of the homebrew bug fixes.

[hrydgard]

Right, I missed the command line path - added a fix now to replace the slashes already there. Could probably remove the other fix now, but meh.

Did not add any explicit support for relative paths yet.

[hrydgard]

This is good enough now I think, closing.

[unknownbrackets]

It at least used to be you could use relative paths. I think at some point PPSSPP was changed to chdir to its own directory, so I guess they might be relative to its directory now?

-[Unknown]

[tilkinsc]

Relative paths are working fine.