Windows tablet (z8300) cannot scroll down since v1.3-918-ge17772b

[sum2012]

@unknownbrackets
That mean #9430
User report from baidu

[hrydgard]

This is when using touch, I assume? Maybe we aren't properly sending touch move events while touch is held down on Windows, or something... Touch works through the UWP APIs but we use a different path for touch in the desktop version.

[sum2012]

He tell me that use touch to scroll

[unknownbrackets]

Ah. I see it:

	if ((input.flags & TOUCH_DOWN) && input.id == 0) {
		scrollStart_ = scrollPos_;
		inertia_ = 0.0f;
	}

Only input.id == 0 is allowed to scroll. To avoid clashes the code is skipping the mouse id (0), because the code had a comment indicating it was doing something to avoid interfering with the mouse (even though it looked broken.)

https://github.com/hrydgard/ppsspp/pull/9430/files#diff-c3532e1a49254f9d8a00e53675aa251aR50

We can probably change this to 0, probably unlikely people will touch and use a mouse simultaneously. But I wonder if scrolling only for touch.id == 0 is best or not...

-[Unknown]

[hrydgard]

I think the idea for the ==0 check was to avoid multiple simultaneous touches interfering with each other. It might also be viable to grab a touchID on touch down, and ignore all other touch events in that scrollview until that touch has been released. That would also make it possible to scroll two views simultaneously with different fingers which I guess would be kinda cool.

[hrydgard]

That change should fix it up.

[sum2012]

I will give him try

[sum2012]

He tell me v1.4-43, the touch point is not correct.
For example.click "Setting" ,ppsspp pop up "Load ..." in the menu.
This is no problem in v1.3

[hrydgard]

OK, strange.. Might be related to the DPI fixes. I'll check and see if I find something obvious.

[hrydgard]

I found something, at least. Please test again :)

[sum2012]

I tell him test again.
One other thing,this issue of Milestone should be mark as v1.5 or v1.4.2 ?

[hrydgard]

Not sure if I'll release a 1.4.1 or go directly to 1.5. 1.4 has some bugs like this though..

[sum2012]

He has another problem on ppsspp on UI.
But I want to solve this first.
So that we don't confuse.

[hrydgard]

Sounds resonable. Now, did this last change work?

[sum2012]

Thanks ,He test on v1.4-48 ,fixed touch point ,closing this issue,I will open another issue for other UI problem

[sum2012]

He said that top to down scroll still not fix
So I reopen

[unknownbrackets]

Maybe here too?

ppsspp/ext/native/input/gesture_detector.cpp

Line 100 in 2019542

info[0] = pointers[0].lastX - pointers[0].downX;

-[Unknown]

[hrydgard]

Oh, indeed. I'll fix that too.

[hrydgard]

Committed another fix, I believe this should work now.

Thanks @sum2012 + friend for all the testing.

[sum2012]

Unlucky V1.4-50 still not fix top to down scroll

[hrydgard]

Sigh, of course, I forgot an important detail... hang on.

[hrydgard]

@sum2012 hopefully that will do it. sorry :)

[hrydgard]

And one more to fix bugs from that one :)

[sum2012]

Thanks v1.4-52 fix top to down scroll
Remain #9563 problem
Closing