Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot max resolution limit #11245

Merged
merged 1 commit into from Jul 9, 2018
Merged

Conversation

weihuoya
Copy link
Contributor

@weihuoya weihuoya commented Jul 9, 2018

high resolution screenshot got large jpg file and really slow down SavedataScreen, especially on pc.
x1 is a little fuzzy, x2 is fine.

@unknownbrackets
Copy link
Collaborator

Which backend does it slow down? Maybe it's slow mipmap generation.

I guess this is fine, but maybe someone with 4K might consider 2x blurry...

-[Unknown]

@weihuoya
Copy link
Contributor Author

weihuoya commented Jul 9, 2018

test opengl and vulkan, GamePauseScreen slow down a little, too.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Jul 9, 2018

Meanwhile most of the actual users actually don't care about screenshots freezing or doing whatever to the game as they use it to capture a moment and want to capture either eactly what they see as it works by default or even an extremely high res that could take a few seconds to make even if they loose post process filters. As such, I think this pr is unacceptable unless made optional and not enabled by default.

Edit: blah, didn't notice it's for savestate only, still I don't like forcing people to low res pictures for something that still captures a moment and some wish to view it later.

@hrydgard
Copy link
Owner

hrydgard commented Jul 9, 2018

I'm fine with this as it's savestate only, it's still possible to take nice high res pictures if you want them, savestate screenshots are just for knowing where you are in the game. If anyone cares enough to have a hidden option to preserve full resolution, I would be OK with that too but really don't think this is worth a UI string.

@hrydgard hrydgard merged commit 7e14a61 into hrydgard:master Jul 9, 2018
@weihuoya weihuoya deleted the screenshotx2 branch July 10, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants