Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct various light param issues based on tests #11574

Merged
merged 7 commits into from
Nov 22, 2018
Merged

Correct various light param issues based on tests #11574

merged 7 commits into from
Nov 22, 2018

Commits on Nov 19, 2018

  1. SoftGPU: Fix pixel mask on rectangle clear. 

    Oops, had inverted it.  This caused it to improperly clear when masked.
    @unknownbrackets
    unknownbrackets committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    10fa20c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. Reporting: Ignore link error with bad shaders. 

    We only need the issue reported once.
    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    c944063 View commit details
    Browse the repository at this point in the history

  2. GPU: Skip specular on powered diffuse. 

    Matches hardware tests and improves lighting for Virtua Tennis, see hrydgard#4140.
    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    9a4cd5b View commit details
    Browse the repository at this point in the history

  3. GPU: Handle spot light with 0 exp or length.

    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    1cec9f5 View commit details
    Browse the repository at this point in the history

  4. GPU: Correct powered diffuse with exp=0. 

    Just to ensure negative factors are handled too, as they are on hardware.
    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    6e46d6c View commit details
    Browse the repository at this point in the history

  5. GPU: Skip specular on negative diffuse factor. 

    This is correct per hardware tests, see hrydgard#8403.  Note that the PS3 emulator
running PSP HD remasters does not correctly handle this, and applies
specular for negative diffuse factor.
    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    4816bfc View commit details
    Browse the repository at this point in the history

  6. GPU: Correct specular exponent zero.

    @unknownbrackets
    unknownbrackets committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    1c19bce View commit details
    Browse the repository at this point in the history