Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for notched phones #12264

Closed
wants to merge 1 commit into from
Closed

Conversation

Florin9doi
Copy link
Contributor

Needs testing, some settings may became inaccessible

@hrydgard
Copy link
Owner

Thanks! I've tried similar stuff but had issues on my notched phone, I'll test it later before I merge.

@hrydgard hrydgard added this to the v1.9.0 milestone Aug 21, 2019
@hrydgard
Copy link
Owner

Yeah, this is gonna need additional work. With fullscreen off, I get that white edge I could never get rid of:
fullscreen_off

And with fullscreen on, the UI is clipped and needs fixing:
fullscreen_on

Right now I don't see how it's worth it - PSP games at approximately 16:9 just aren't wide enough for this to matter at all.

@unknownbrackets
Copy link
Collaborator

It seems like the ideal thing would be to make the notch area black.

-[Unknown]

@hrydgard
Copy link
Owner

Yeah, which is what currently happens without this pull request..

@unknownbrackets
Copy link
Collaborator

I guess I might want to put buttons near the notch, at most... then again, I'm planning to avoid notch phones for as long as I can.

-[Unknown]

@Florin9doi
Copy link
Contributor Author

Right now I don't see how it's worth it - PSP games at approximately 16:9 just aren't wide enough for this to matter at all.

You're right

@Florin9doi Florin9doi closed this Aug 23, 2019
@hrydgard
Copy link
Owner

hrydgard commented Aug 23, 2019

Well, I do want to extend the UI out into the notched area later - but I'm gonna postpone it to 1.10. Although yeah, this PR can be closed, leaving #12261 open.

@hrydgard hrydgard reopened this Aug 23, 2019
@hrydgard hrydgard closed this Aug 23, 2019
@hrydgard hrydgard removed this from the v1.9.0 milestone Aug 23, 2019
@Florin9doi Florin9doi deleted the 12261 branch August 31, 2019 08:16
@Halo-Michael
Copy link
Contributor

And Please add FullScreen Button for iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants