Use the alloc size from real PSP for FONT_OPEN_INTERNAL_STINGY mode. #13180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice find! |
hrydgard
reviewed
Jul 22, 2020
| @@ -613,7 +618,7 @@ class FontLib { | |||
|
|
|||
| u32 allocSize = 12; | |||
| if (mode == FONT_OPEN_INTERNAL_STINGY) { | |||
| allocSize = 0x239B4; | |||
| allocSize = loadedFont->GetFont()->getStingySize(); | |||
There was a problem hiding this comment.
a little curious that this one is = and the other one +=. Maybe the bias of 12 is builtin to the non-stingy sizes?
|
Fix pspautotests link: edit:I need gid15 to find gb3s1518.bwfon's StingySize |
gid15
added a commit
to jpcsp/jpcsp
that referenced
this pull request
Jul 24, 2020
memory size as on a real PSP. Tested for all the PSP fonts. Based on hrydgard/ppsspp#13180 by shenweip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values are from pspautotest, see hrydgard/pspautotests#206 . Should helps #13166 , this game uses FONT_OPEN_INTERNAL_STINGY mode to open font files(index 0, 1 and 11), the alloc size seems incorrect before.