Mpeg: prevent some cases where a valid mpeg stream was being flagged as invalid. #13442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
called with a small read size.
|
Well, the problem is that we can't send the data early or it will break some games. See #8803. How will this make it still return ERROR_MPEG_INVALID_VALUE to the game in the corerct cases? Perhaps we should remove or lessen the logging, but I'm pretty sure this change will make the tests of invalid mpeg data fail again. We shouldn't be altering behavior and deviating from what games expect just to reduce logging. Games actually do check error codes and misbehave when they are incorrectly told failures are successful. -[Unknown] |
|
well it isn't really just about the logging but about the flag being incorrectly set. |
|
actually, just tested |
|
Logically, looking at the code, this does not seem correct. It needs more data to tell whether the stream is valid. Obviously there's some other higher level bug that this manages to paper over though in some cases like in Powered Up. |
|
@aliaspider can you test again "Mega Man Powered Up" ? |
|
@shenweip do you interest to fix "Mega Man Powered Up"'s video (if you have the game) |
|
Is there a log file about this? |
|
v1.10.3-1245-g51b213e68-windows-amd64 |
|
|
|
Update log to v1.10.3-1257-g6bf9f20f5-windows-amd64 |
|
I try many many game.Only this game's mpegLibVersion = 260 edit: |
|
sceMpeg 0x104 is used by the following games (and possibly others):
-[Unknown] |
|
Very thanks @unknownbrackets |
|
When invalid data is detected, I wonder if we can keep the previous data and just reject the later data to reduce data loss. |
|
Update log to v1.10.3-1402-g8bc1f3ee9-windows-amd64 @shenweip you can ask me do some mpeg JPCSPTrace log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids spamming the console with the
sceMpegRingbufferPut(): invalid mpeg dataerror, for example during the intro video ofMega Man Powered Up