Create a safer variant of BlockTransferAllowCreateFB, enable for FF Type 0 #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype 0 Performance improvement by avoiding unnecessary readbacks. New one is called IntraVRAMBlockTransferAllowCreateFB. This one only allows intra-VRAM block transfers to happen on-GPU, such as the one this game uses for bloom. Good chances to avoid missing stuff that actually requires real readback, if there's any.
|
|
|
Didn't see any improvement either , unless I didn't have it enabled or something. |
|
Okay, seems the readback I got rid of was mostly affecting cutscenes. I have some more ideas of what might be slowing this down, stay tuned. |
|
And the game itself crashes upon loading on the latest build from today, but only on GL. Git 894 doesn't suffer from such issue. |
|
Oh yeah, I think I know what that is. I'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should give it a considerable boost by avoiding readbacks, see #13464 .
New compat setting is called IntraVRAMBlockTransferAllowCreateFB.
This one only allows intra-VRAM block transfers to happen as copies on-GPU, such as the one this game uses for bloom. Not readbacks to RAM. Good chances to avoid missing stuff that actually requires real readback, if there's any.