Shader generation: Start sharing some parts between backends #13551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a potential error with tesselation without normals already.
hrydgard
force-pushed
the
shader-refactor
branch
from
d7b5040
to
b6ca5d9
Compare
|
Got a bit scared of breakage here, so made a brute force shader generator verifier (D3D11/Vk only since they have offline compilers that don't need an active device) and added to the unit test project. It found some bugs and might find more once I add the various GLSL and D3D9 paths... |
|
I've decided to approach this from the other direction: First get the shader generator test in, which will require some mild surgery in the GLSL generation due to the insane variety of shader language versions it supports. And only then start refactoring. This should minimize the risk of breakage properly. All the work here will be reused then, of course. |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to add some new capabilities to shader blend replacement, to fix some issues with masking for example (I think I'll be able to solve Outrun's car reflection color, for example). To be able to only (mostly) do these changes in one place, I here split out that part from all the shader generators so it can be shared between them.
This requires injecting a few compatibility defines and renaming some uniforms, but I think it'll be worth it.