Early-out in texture replacement code, if replacement disabled #15431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added a commit
that referenced
this pull request
Apr 8, 2022
Was hoping to find the cause of the issue I looked at in #15431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick work-around for a crash reported on Discord by Azuka and .QrTa, in the case of texture replacement disabled. Bug still seems to exist though, likely some race condition in the threadmanager, or similar.
Without this, due to bReplaceTexturesAllowLate, every single texture creation ends up spawning a task and waiting for it, whether replacement is enabled or not.
Reproduces easiest in the main menu of Gran Turismo when lots of text is showing.
QrTa narrowed the crash down to 1.12.324-1.12.389, so will look at that next. Which is aa12c9b..aa12c9b . Between those are two thread-manager releated PRs, #15178 and #15205. The first one had a race condition that we later fixed that only happened on ARM - there might be more gremlins there.