GPU: Avoid bloom hack on buffers used for depth #16565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
force-pushed
the
bloom-hack
branch
from
3031bc4
to
d6d82b8
Compare
unknownbrackets
force-pushed
the
bloom-hack
branch
2 times, most recently
from
f20c88b
to
ffb731f
Compare
If a buffer even has depth transferred to it, let's avoid lowering its resolution.
unknownbrackets
force-pushed
the
bloom-hack
branch
from
ffb731f
to
e5d6711
Compare
|
Might be nice to merge this @hrydgard. -[Unknown] |
|
Yeah, let's try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a buffer even has depth transferred to it, let's avoid lowering its resolution.
This isn't well tested (it doesn't break things, but there's a bunch of games to check), but the goal is to avoid manually tracking ForceLowerResolutionForEffectsOff on a bunch of games. If it uses depth as color, we pretty much never want to size it down.
-[Unknown]