Simplify the touch d-pad code. #18028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to #17950 I had a look at this code and found some room to simplify, but I don't think this is likely to fix anything.
hrydgard
added
the
Code Cleanup
| if (pressed & dir[i]) { | ||
| if (g_Config.bHapticFeedback) { | ||
| System_Vibrate(HAPTIC_VIRTUAL_KEY); | ||
| __CtrlUpdateButtons(ctrlMask, CTRL_LEFT | CTRL_RIGHT | CTRL_UP | CTRL_DOWN); |
There was a problem hiding this comment.
I guess this makes the assumption that you would never use two inputs at once that affect the dpad. Before it was careful to only release things that were changed, but now any touch to the d-pad will FORCE release any other directions.
So if you have a combo key that presses say, up and triangle for some reason - and then you press left, the up button will be force released and discarded.
Is that intentional? I don't know if any games might motivate that sort of combo button, but it doesn't seem impossible at all.
-[Unknown]
There was a problem hiding this comment.
Oh, hm, I overlookee that. Might change it back
There was a problem hiding this comment.
Noticed I forgot to fix this. Fix going into 1.16.1
hrydgard
added a commit
that referenced
this pull request
Sep 11, 2023
hrydgard
added a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #17950 I had a look at this code and found some room to simplify (now we never do more than one __CtrlUpdateButtons call), but I don't think this is likely to fix anything.