Fix the semantics of DenseHashMap to be consistent even when inserting nulls#18129
Merged
Fix the semantics of DenseHashMap to be consistent even when inserting nulls#18129
Conversation
hrydgard
added
the
Code Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've always had an uncomfortable ambiguity where you could insert nulls, but they'd return null like they weren't there and there was no way to check if a null had actually been inserted before, leading to double-insert asserts if you checked for an existing item before inserting but the previous item was a nullptr.
With this, the semantics are more normal. This allows us to fix one of the crashes from #18116.