More assorted fixes #18248
Merged
More assorted fixes #18248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Sep 27, 2023
| @@ -590,6 +590,8 @@ void SoftwareTransform::BuildDrawingParams(int prim, int vertexCount, u32 vertTy | |||
| result->drawBuffer = transformedExpanded; | |||
| result->drawIndexed = true; | |||
| } else if (prim == GE_PRIM_LINES) { | |||
| // TODO: What about GE_PRIM_LINE_STRIP? | |||
There was a problem hiding this comment.
Doesn't indexGen always turn them into lines? I don't think it tries to keep line strip if "pure".
-[Unknown]
There was a problem hiding this comment.
Mm, I guess it does, yeah.
hrydgard
force-pushed
the
assorted-fixes-12
branch
from
4a70cfd
to
84d0236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor stuff this time.